Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade jdk version #10075

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat: upgrade jdk version #10075

merged 1 commit into from
Jan 20, 2025

Conversation

guillaumelamirand
Copy link
Contributor

@guillaumelamirand guillaumelamirand commented Dec 6, 2024 •
edited by graviteeio
Loading

Issue

https://gravitee.atlassian.net/browse/ARCHI-425

Description

A change in the representation of certain double force me to update a unit test.

BREAKING CHANGE: jdk used for compilation needs to be upgrade to 21

Additional context

📚  View the storybook of this branch here

@guillaumelamirand guillaumelamirand force-pushed the archi-425 branch 5 times, most recently from f381634 to d19d424 Compare December 6, 2024 14:22
@guillaumelamirand guillaumelamirand force-pushed the archi-425 branch 2 times, most recently from 1b36110 to 4d166a4 Compare December 6, 2024 15:08
@cypress Cypress
Copy link

cypress bot commented Dec 6, 2024

APIM UI Tests    Run #3239

Run Properties:  status check failed Failed #3239  •  git commit 4d166a4281: feat: upgrade jdk version
Project APIM UI Tests
Branch Review archi-425
Run status status check failed Failed #3239
Run duration 07m 06s
Commit git commit 4d166a4281: feat: upgrade jdk version
Committer Guillaume Lamirand
View all properties for this run ↗︎
Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 8
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 79
View all changes introduced in this branch ↗︎

Tests for review

Failed  ui-test/integration/apim/ui/apis/ui-api-info.spec.ts • 3 failed tests

View Output Video

Test Artifacts
API Info Page functionality > Danger Zone - Publish and Unpublish the API Test Replay Screenshots Video
API Info Page functionality > Danger Zone - Make Public and Make Private the API Test Replay Screenshots Video
API Info Page functionality > Danger Zone - Deprecate the API Test Replay Screenshots Video

@guillaumelamirand guillaumelamirand force-pushed the archi-425 branch 3 times, most recently from 7fc5dba to 03f1872 Compare December 9, 2024 09:17
@guillaumelamirand guillaumelamirand marked this pull request as ready for review January 6, 2025 16:07
@guillaumelamirand guillaumelamirand requested a review from a team as a code owner January 6, 2025 16:07
@guillaumelamirand guillaumelamirand force-pushed the archi-425 branch 2 times, most recently from 87d02f4 to a71eb69 Compare January 16, 2025 10:27
@guillaumelamirand guillaumelamirand force-pushed the archi-425 branch 4 times, most recently from 166f059 to 07ea571 Compare January 20, 2025 14:21
@guillaumelamirand guillaumelamirand enabled auto-merge (rebase) January 20, 2025 14:47
@guillaumelamirand guillaumelamirand merged commit f8958da into master Jan 20, 2025
35 of 38 checks passed
@guillaumelamirand guillaumelamirand deleted the archi-425 branch January 20, 2025 15:05
@jgiovaresco jgiovaresco mentioned this pull request Feb 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhaeyaert jhaeyaert jhaeyaert approved these changes

@phiz71 phiz71 phiz71 approved these changes

Assignees
No one assigned
Labels
run-e2e-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaumelamirand @jhaeyaert @phiz71